Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Waltz metrics documentation to wiki #18

Open
whynick1 opened this issue Jul 8, 2019 · 0 comments
Open

Add Waltz metrics documentation to wiki #18

whynick1 opened this issue Jul 8, 2019 · 0 comments

Comments

@whynick1
Copy link
Contributor

whynick1 commented Jul 8, 2019

We should agree and document on naming convention of metrics before proceeding further.

I think using a class name as a part of a metric name is expressively long and not so useful for monitoring. I'd rather have names like "waltz-server" and "waltz-storage" as top level names. We can map these to domain names in JMX. The second level may be "partition-", which may be mapped to a type name in JMX. I am not sure if it is useful to add metric type name ("counter", "meter", "gauge") at the end of the metric name.

So, my preference is something like "waltz-server.partition-1.high-water-mark". It appears in console like this:

·waltz-server
        ·partition-1
                ·high-water-mark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant