Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to update the pypi package? #354

Open
MiniXC opened this issue Aug 27, 2024 · 5 comments
Open

Any plans to update the pypi package? #354

MiniXC opened this issue Aug 27, 2024 · 5 comments

Comments

@MiniXC
Copy link

MiniXC commented Aug 27, 2024

I'm assuming wespeakerruntime is the official pypi package, but it hasn't been updated since Feb 2023.

Having wespeaker as a pypi package would be useful for publishing libraries that depend on it, as packages with github dependencies cannot be published on pypi themselves.

Edit: I also think the wespeaker name would still be free: https://pypi.org/project/wespeaker/

@wsstriving
Copy link
Collaborator

Thanks for the suggestion, can @cdliang11 and @pengzhendong help to follow this?

@wsstriving
Copy link
Collaborator

wsstriving commented Aug 27, 2024

By the way, currently you can install using pip install git+https://github.com/wenet-e2e/wespeaker.git

@MiniXC
Copy link
Author

MiniXC commented Aug 31, 2024

Yes I'm using this method, however it does not work for declaring it as a dependency for another package (that's to be published on pypi)

@JiJiJiang
Copy link
Collaborator

Hi @MiniXC , thanks for usage! Could you please put the error message here?

@MiniXC
Copy link
Author

MiniXC commented Sep 3, 2024

It is basically this when I try to publish my package using the wespeaker repository as a dependency:

HTTPError: 400 Client Error: Invalid value for requires_dist. Error: Can't have direct dependency: 'wespeaker @ git+https://github.com/wenet-e2e/wespeaker.git' for url: https://upload.pypi.org

More detail about why only pypi packages can be used as dependencies this way can be found here: https://stackoverflow.com/a/54894359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants