From 88217acc26483f4b3a543db2865b4c6a59fac1c7 Mon Sep 17 00:00:00 2001 From: Oleg Isonen Date: Wed, 18 Dec 2024 18:00:07 +0000 Subject: [PATCH] fix: hide background mode from the user in vimeo component (#4618) ## Description This mode is a combination of loop and autoplay and controls, so one can make it, currently its confusing because it doesn't affect these controls when toggling it ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file --- packages/sdk-components-react/src/vimeo.ws.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/sdk-components-react/src/vimeo.ws.ts b/packages/sdk-components-react/src/vimeo.ws.ts index a8b15bc4c2bd..2830aaf7972c 100644 --- a/packages/sdk-components-react/src/vimeo.ws.ts +++ b/packages/sdk-components-react/src/vimeo.ws.ts @@ -320,10 +320,9 @@ const initialProps: Array> = [ "className", "url", "quality", + "loading", "showPreview", "autoplay", - "loading", - "backgroundMode", "doNotTrack", "loop", "muted",