Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimedItem.prototype _hasFutureEffect #509

Open
KevinDoughty opened this issue Dec 9, 2013 · 0 comments
Open

TimedItem.prototype _hasFutureEffect #509

KevinDoughty opened this issue Dec 9, 2013 · 0 comments

Comments

@KevinDoughty
Copy link

Hello, I know this isn’t a diff, and the code might not be correct, but I am really looking forward to this one being completed. My stuff uses a lot of memory which otherwise does not get released. In TimedItem.prototype, something like this:

// Note that this restriction is currently incomplete - for example,
// Animations which are playing forwards and have a fill of backwards
// are not in effect unless current.
// TODO: Complete this restriction.
_hasFutureEffect: function() {
return this._isCurrent() || this.specified.fill === 'both' ||
(this.specified.fill === 'backwards' && !this._isCurrentDirectionForwards()) ||
(this.specified.fill === 'forwards' && this._isCurrentDirectionForwards());
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant