Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fizzy-spectests doesn't use import resolve API #645

Open
gumb0 opened this issue Nov 17, 2020 · 0 comments
Open

fizzy-spectests doesn't use import resolve API #645

gumb0 opened this issue Nov 17, 2020 · 0 comments

Comments

@gumb0
Copy link
Collaborator

gumb0 commented Nov 17, 2020

resolve_imported_functions and other resolve_* functions from #637 in their current form are not convenient to use to link exports/imports of several modules together. Resolve API and suits more to import host functions (because of convenience of flattened ImportedFunction struct and other Imported* - fewer curly braces on the caller side).

Importing from one module to another requires External* structs - which are returned from find_exported_* functions - that's what spectest runner uses.

Perhaps resolve API could be improved to accomodate both needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant