-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog about major version 6 ? #74
Comments
Hi @ouraios. There was a major rewrite done by @switzer. I was concerned that with such a rewrite something may have broken backwards compatibility, which is why I did the major version bump. I believe that none of the tests were changed and all of the tests continued to pass after the rewrite. So, if something has changed, I would say that was unintentional and there must not have been a test covering that use case. So, sadly, I do not have a concise list of what has changed. However, if you can give me a failing test case, we can add it to the tests and then try to get it fixed up. |
Thanks for your answer @wankdanker As you can see the difference is that in 5.0.0 activityList still appeared after mapping being empty but in 6.2.0 it gets deleted after mapping 😞 I hope you'll be able to find a goof fix for that test case ! And really thank you for your great work on this package ! |
This code works in 5.0.0 but doesn't work in >=6.0.0. |
I've updated to the major version 6 but because of the lack of changelog and possible breaking changes im not able to understand the return objects are not exactly the same between version 5 & 6.
Could you please @wankdanker make a changelog explaining what are the big changes in major version 6 against 5 ? That would help everyone ... because right now i had no choice but to rollback to version 5 :/
The text was updated successfully, but these errors were encountered: