Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request | Add support for topologySpreadConstraints #308

Open
vijay-wandb opened this issue Nov 20, 2024 · 3 comments · May be fixed by wandb/helm-charts#273
Open

Feature Request | Add support for topologySpreadConstraints #308

vijay-wandb opened this issue Nov 20, 2024 · 3 comments · May be fixed by wandb/helm-charts#273
Assignees
Labels
Priority-P2 Medium priority for the request

Comments

@vijay-wandb
Copy link

Similar to how @flamarion added support for the security context in this PR, we need to implement the same for topologySpreadConstraints

Sample block

   topologySpreadConstraints:
        - maxSkew: 1
          topologyKey: kubernetes.io/hostname
          whenUnsatisfiable: ScheduleAnyway
          labelSelector:
            matchLabels:
              control-plane: controller-manager
        - maxSkew: 1
          topologyKey: topology.kubernetes.io/zone
          whenUnsatisfiable: ScheduleAnyway
          labelSelector:
            matchLabels:
              control-plane: controller-manager
@vijay-wandb vijay-wandb self-assigned this Nov 20, 2024
@vijay-wandb vijay-wandb added the Priority-P2 Medium priority for the request label Nov 20, 2024
@vijay-wandb vijay-wandb changed the title Add support for topologySpreadConstraints Feature Request | Add support for topologySpreadConstraints Nov 20, 2024
@velotioaastha
Copy link
Contributor

Hi @vijay-wandb Can you please confirm if support for topologySpreadConstraints should be added at a global level (meaning it would be same for all the subcharts) or for individual components within their own subchart configurations?

@vijay-wandb
Copy link
Author

@velotioaastha Lets go with the global level for now. If it doesn’t work for Ford, I will raise a new FR. Supporting both options in the future could help customers in the long run.

@abhinavg6
Copy link

@theishshah will review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority-P2 Medium priority for the request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants