Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Transmit apodization/window is never applied to transducer source. #518

Open
brubbel opened this issue Nov 25, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@brubbel
Copy link
Contributor

brubbel commented Nov 25, 2024

Describe the bug
In kWaveSimulation.py, the transmit_apodization_mask is assigned to self.transducer_transmit_apodization, but it does not appear to be applied to the input signal at any point in the code.

To Reproduce
(examples/us_bmode_phased_array)
In ktransducer,py, set the return value of transmit_apodization_mask to an all-zero mask.
No difference in the simulation results.

Expected behavior
windowing is applied to the input signal.

@brubbel brubbel added the bug Something isn't working label Nov 25, 2024
@waltsims
Copy link
Owner

@brubbel Thanks for reporting this. Please look at the relicensing we began this past week. We need your input to move forward.

@waltsims
Copy link
Owner

Hi @brubbel, Just following up on the relicensing issue. Please follow the steps there so we can move forward. Feel free to contact me via e-mail if you have any questions. walter.a.simson [at] gmail.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants