Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory usage in FFTs #348

Open
djps opened this issue Mar 19, 2024 · 1 comment
Open

Reduce memory usage in FFTs #348

djps opened this issue Mar 19, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@djps
Copy link
Collaborator

djps commented Mar 19, 2024

Is your feature request related to a problem? Please describe.
Post-processing currently always auto-casts to double precision for methods that use scipy.fftpack, e.g. extract_amp_and_phase. This can lead to OOM needless errors e.g. there have been cases where the simulation has run, but I have been unable to take the Fourier transform as I run out of memory.

Describe the solution you'd like

  • use scipy.fft instead of scipy.fftpack or numpy.fft as this does not automatically cast to double precision
  • ensure that get_win and extract_amp_phase keep the same precision as the data which is supplied.

Describe alternatives you've considered
The new numpy 2.0 will have this capability, as it also upcasts, see issue.

@djps djps added the enhancement New feature or request label Mar 19, 2024
@djps djps added this to the v0.3.4 milestone Mar 19, 2024
@djps djps self-assigned this Mar 19, 2024
@waltsims
Copy link
Owner

@waltsims waltsims modified the milestones: v0.3.4, v0.3.5 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants