-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links defined in anchors
section in bikeshed classified as "autolinks"
#1584
Comments
conversely, bikeshed generates links for the automatically generated index sections without |
I note that, in some specs, the asides appear after the We could probably exclude aside elements that have a |
Via #1584 (comment). Aside dfn panels only contain links that already appear somewhere else in the spec. These links were extracted and categorized as `autolinks` when they appeared in the final index of a Bikeshed spec, which essentially did not do anything because the links had already been extracted as `autolinks` in any case. The problem is that Respec also uses similar panels (but no `<aside>`), and Bikeshed sometimes outputs the panels at the end of the document, and not within the index itself as expected in the code. In these situations, the links were extracted a second time, as `rawlinks`. Not extracting the panels avoids duplication entirely.
Via #1584 (comment). Aside dfn panels only contain links that already appear somewhere else in the spec. These links were extracted and categorized as `autolinks` when they appeared in the final index of a Bikeshed spec, which essentially did not do anything because the links had already been extracted as `autolinks` in any case. The problem is that Respec also uses similar panels (but no `<aside>`), and Bikeshed sometimes outputs the panels at the end of the document, and not within the index itself as expected in the code. In these situations, the links were extracted a second time, as `rawlinks`. Not extracting the panels avoids duplication entirely.
in #1518 we started distinguishing between
rawlinks
andautolinks
to simplify and reduce false positive in broken link detection in strudy.I realized today that the heuristic to distinguish between the two is not working so well for bikeshed: links that are defined in
<pre class='anchors'>
sections get classified as autolinks whereas in fact they're manually maintained URLs.I don't think there is an easy way to fix this short of changing bikeshed to markup these links differently.
(conversely, if/when we fix it, we would be able to detect systematically links that are defined in
anchors
section but don't need to be)The text was updated successfully, but these errors were encountered: