Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-inline-3] -top/-bottom vs -over/-under #11365

Open
fantasai opened this issue Dec 13, 2024 · 1 comment
Open

[css-inline-3] -top/-bottom vs -over/-under #11365

fantasai opened this issue Dec 13, 2024 · 1 comment

Comments

@fantasai
Copy link
Collaborator

fantasai commented Dec 13, 2024

We historically have had top/bottom values for vertical-align etc; but in vertical text these don't make a whole lot of sense, since they're on the left or right of the line.

For the <text-edge> values introduced by #10713 , what do we want to do?

  • Keep text-top and text-bottom, introduce ideographic-top and ideographic-bottom, for consistency.
  • Keep text-top and text-bottom, introduce ideographic-over and ideographic-under, keeping consistency with existing keywords, but establishing a new pattern going forward.
  • Use text-over and text-under, breaking consistency with vertical-align; and introduce ideographic-over and ideographic-under.
@MurakamiShinyu
Copy link
Collaborator

I don't think ideographic-over/under is better than ideographic-top/bottom. I prefer ideographic-top and ideographic-bottom for consistency with existing text-top and text-bottom keywords, and for similarity with OpenType Baseline Tags such as idtp (ideographic top).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants