Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-inline-3] Improve illustrations for text edges #11364

Open
fantasai opened this issue Dec 13, 2024 · 1 comment
Open

[css-inline-3] Improve illustrations for text edges #11364

fantasai opened this issue Dec 13, 2024 · 1 comment

Comments

@fantasai
Copy link
Collaborator

Follow up from seek-oss/capsize#205 (comment) and #10703 (comment) -- the illustrations in the spec conflate the cap height with the ascent, and need to be redone.

@sciascia
Copy link

sciascia commented Dec 20, 2024

In addition to the comments above (and sorry if I'm misunderstanding something basic) but why is text-edge: leading; not actually leading?

text-edge

If I'm understanding the illustration correctly, text-edge: leading; is actually line-height which splits the space evenly above and below the text, creating half leading which is the problem to begin with.

As a designer, I would expect text-edge: leading; to make the text behave like leading!

To properly reflect the spacing behaviour, shouldn't the properties be changed to the following...

  1. text-edge: leading; becomes text-edge: line-height;
  2. text-edge: text; becomes text-edge: leading?

#11364 #10703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants