Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tags for test suites that are not associated with this implementations repo and update README.md #91

Merged
merged 14 commits into from
Dec 14, 2023
Merged

Remove tags for test suites that are not associated with this implementations repo and update README.md #91

merged 14 commits into from
Dec 14, 2023

Conversation

JSAssassin
Copy link
Contributor

@JSAssassin JSAssassin commented Dec 11, 2023 •
edited
Loading

Addresses #85 and #89

@JSAssassin JSAssassin changed the title Update README.md section for tags for Status List 2021 test suite Update README.md tags section for Status List 2021 test suite Dec 11, 2023
@JSAssassin JSAssassin force-pushed the update-readme branch 3 times, most recently from 3fb3954 to c5910c3 Compare December 11, 2023 19:42
@JSAssassin JSAssassin marked this pull request as draft December 11, 2023 19:47
@JSAssassin JSAssassin marked this pull request as ready for review December 11, 2023 21:54
@JSAssassin JSAssassin changed the title Update README.md tags section for Status List 2021 test suite Remove tags for test suites that are not associated with this implementations repo and update README.md Dec 11, 2023
BigBlueHat
BigBlueHat reviewed Dec 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
BigBlueHat
BigBlueHat approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This should help clarify what's what. 😄

aljones15
aljones15 reviewed Dec 12, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
aljones15
aljones15 suggested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but needs some clarification.

README.md Outdated Show resolved Hide resolved
@JSAssassin JSAssassin requested a review from aljones15 December 12, 2023 17:24
aljones15
aljones15 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes LGTM

BigBlueHat
BigBlueHat approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @JSAssassin!

@JSAssassin JSAssassin merged commit a4ba809 into main Dec 14, 2023
2 checks passed
@JSAssassin JSAssassin deleted the update-readme branch December 14, 2023 18:39
This was referenced Dec 14, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljones15 aljones15 aljones15 approved these changes

@BigBlueHat BigBlueHat BigBlueHat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JSAssassin @BigBlueHat @aljones15