From 1dfd2b0aa186a398e7814cb5779fa039c6b14d59 Mon Sep 17 00:00:00 2001 From: Charles Cooper Date: Fri, 27 Dec 2024 09:11:16 -0500 Subject: [PATCH 1/2] fix[lib]: fix `IERC4626` signatures the signatures should not have default parameters; if used, they will create a different method id at the callsite than the `ERC4626` standard actually accepts. --- vyper/builtins/interfaces/IERC4626.vyi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vyper/builtins/interfaces/IERC4626.vyi b/vyper/builtins/interfaces/IERC4626.vyi index 6d9e4c6ef7..0dd398d1f3 100644 --- a/vyper/builtins/interfaces/IERC4626.vyi +++ b/vyper/builtins/interfaces/IERC4626.vyi @@ -44,7 +44,7 @@ def previewDeposit(assets: uint256) -> uint256: ... @external -def deposit(assets: uint256, receiver: address=msg.sender) -> uint256: +def deposit(assets: uint256, receiver: address) -> uint256: ... @view @@ -58,7 +58,7 @@ def previewMint(shares: uint256) -> uint256: ... @external -def mint(shares: uint256, receiver: address=msg.sender) -> uint256: +def mint(shares: uint256, receiver: address) -> uint256: ... @view @@ -72,7 +72,7 @@ def previewWithdraw(assets: uint256) -> uint256: ... @external -def withdraw(assets: uint256, receiver: address=msg.sender, owner: address=msg.sender) -> uint256: +def withdraw(assets: uint256, receiver: address, owner: address) -> uint256: ... @view @@ -86,5 +86,5 @@ def previewRedeem(shares: uint256) -> uint256: ... @external -def redeem(shares: uint256, receiver: address=msg.sender, owner: address=msg.sender) -> uint256: +def redeem(shares: uint256, receiver: address, owner: address) -> uint256: ... From 04e91b3763816371f32f8a516a9915d898e26bf7 Mon Sep 17 00:00:00 2001 From: Charles Cooper Date: Fri, 27 Dec 2024 09:15:46 -0500 Subject: [PATCH 2/2] add stdlib scope --- .github/workflows/pull-request.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml index 2eb0113487..a2f4b5a0d1 100644 --- a/.github/workflows/pull-request.yaml +++ b/.github/workflows/pull-request.yaml @@ -32,6 +32,7 @@ jobs: # docs: documentation # test: test suite # lang: language changes + # stdlib: changes to the stdlib # ux: language changes (UX) # tool: integration # ir: (old) IR/codegen changes @@ -43,6 +44,7 @@ jobs: docs test lang + stdlib ux tool ir