Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should it use Dispatchers.IO given that the watcher service blocks the thread permanently? #3

Open
nkhalasi opened this issue May 19, 2021 · 0 comments
Open

Should it use Dispatchers.IO given that the watcher service blocks the thread permanently? #3

nkhalasi opened this issue May 19, 2021 · 0 comments

Comments

@nkhalasi
Copy link

  1. scope should be a mandatory parameter and should be a custom CoroutineScope with a single thread executor service
  2. scope.launch(Dispatchers.IO) should be replaced with scope.launch
@nkhalasi nkhalasi changed the title Should it use Dispatchers.IO given that the watcher service block the thread permanently? Should it use Dispatchers.IO given that the watcher service blocks the thread permanently? May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nkhalasi