Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvements to the documentation #38

Open
IBG-Projects opened this issue May 8, 2024 · 0 comments
Open

small improvements to the documentation #38

IBG-Projects opened this issue May 8, 2024 · 0 comments

Comments

@IBG-Projects
Copy link

IBG-Projects commented May 8, 2024

Web Components, Default Theme

  1. https://www.vidstack.io/docs/wc/player/api/video-quality?styling=default-theme
    "useVideoQualityOptions" url target => error 404

  2. https://www.vidstack.io/docs/wc/player/components/menus/menu?styling=default-theme

fold-out code box:

audio-submenu,
captions-submenu,
quality-submenu,
speed-submenu

class .vds-menu of the element <media-menu> is missing, exists only for first empty menu.
this should also affect the .vds-button of <media-menu-button> which is also missing in the other examples.
  1. it would be good if the home page had a ready-made testable vidstack player so that you don't have to search for the player at sub sub sub page default-layout https://www.vidstack.io/docs/wc/player/components/layouts/default-layout?styling=default-theme#previews. Users visit the documentation page to get information and test the player, but if the player cannot even be tested directly, this is not ideal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant