-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Improvements #26
Comments
I have marked this issue as "help wanted" as I can always use a hand as well as "hacktoberfest" to take advantage of free labour. |
You could try multi_curl() extension instead of curl() because it has parallel requests and that would save some response time. Also don't forget having a SimpleXMLElement or DOMDocument object, build the XML then write to the file instead of having multiple IO operations. |
@eugenzaharia I'd be cautious of using SimpleXMLElement/whatever else, as it can potentially introduce dependencies and break things for current users. The primary design goal of this script is for it to be able to run reliably in almost any php environment, including the weird ones. Streaming to the file system instead of buffering the file is a result of a constraint, some websites turned out to have a lot of links and would run under low-memory conditions. Basically it runs out of memory less like this. Not really better or worse, design-wise. I'd rather rewrite the entire thing into a dynamic PHP extension if we're rewriting things. |
Performance is below what is desired but it is hard to do anything beyond a certain point.
This issue should never be closed and will track whatever steps are taken towards a more optimised solution along with benchmarks.
The text was updated successfully, but these errors were encountered: