We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When we use req.params().get("something"), we may get inconsistent results for these two GET requests:
req.params().get("something")
/mytest
None
/mytest?nothing=123
Some(Set.empty)
/mytest?something=123
Some(Set(123))
For cases 1. and 2., shouldn't we get the same result for both? None or Some(Set.empty)?
The problematic line seems to be this one:
https://github.com/vert-x/mod-lang-scala/blob/master/src/main/scala/org/vertx/scala/core/http/package.scala#L91
If we had if (set.isEmpty) None else Some(set) (before it was seq.isEmpty) and then we should get None in both cases.
if (set.isEmpty) None else Some(set)
seq.isEmpty
The text was updated successfully, but these errors were encountered:
@Narigo The bug report is correct, do you want send a PR to fix this?
Sorry, something went wrong.
No branches or pull requests
When we use
req.params().get("something")
, we may get inconsistent results for these two GET requests:/mytest
->req.params().get("something")
yieldsNone
/mytest?nothing=123
->req.params().get("something")
yieldsSome(Set.empty)
/mytest?something=123
->req.params().get("something")
yieldsSome(Set(123))
(which is correct in this case)For cases 1. and 2., shouldn't we get the same result for both?
None
orSome(Set.empty)
?The problematic line seems to be this one:
https://github.com/vert-x/mod-lang-scala/blob/master/src/main/scala/org/vertx/scala/core/http/package.scala#L91
If we had
if (set.isEmpty) None else Some(set)
(before it wasseq.isEmpty
) and then we should getNone
in both cases.The text was updated successfully, but these errors were encountered: