Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sockjs hooks should not require all the hooks to be specified #52

Closed
tobias opened this issue Sep 12, 2013 · 1 comment
Closed

sockjs hooks should not require all the hooks to be specified #52

tobias opened this issue Sep 12, 2013 · 1 comment
Milestone
0.2.0

Comments

@tobias
Copy link
Contributor

tobias commented Sep 12, 2013

Currently, specifying only some of the hooks results in NPEs when the hooks are applied, since the reified EventBusBridgeHook doesn't check for the existence of a hook fn before trying to call it.
@tobias tobias closed this as completed in 51d8b39 Sep 12, 2013
@tobias
Copy link
Contributor Author

tobias commented Sep 12, 2013

"recall"? That commit message should say "require".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@tobias