Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the Map extension #32

Open
fitzthum opened this issue Nov 23, 2024 · 0 comments
Open

Using the Map extension #32

fitzthum opened this issue Nov 23, 2024 · 0 comments

Comments

@fitzthum
Copy link

I have been using the annotated_evidence field of the Appraisal, but since it's ctually be an extension, I am thinking about creating my own extension to serve a similar purpose. Where the annotated-evidence takes BTreeMap<String, RawValue>, the map extension looks like Map(Vec<(ExtensionValue, ExtensionValue)>).

This seems sub-optimal. First, it's debatable whether this is a map at all given that it allows duplicate values. More importantly, though, I want to put a somewhat deeply-nested struct into my extension. Ideally I wouldn't have to parse the whole thing into extension types. Any thoughts about changing the extensions to use the existing value structs (or better yet, the ones from the json crate)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant