-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coveralls integration + Codeception #44
Comments
For sure. The tests are currently very ad-hoc, and their only "good" point is that "it's better than no tests at all"... |
Excellent!! |
I have this fork using The current report summary:
|
Now we need to improve this coverage report by adding more tests by each component. |
I found some interesting points in
This report concludes that 4 methods (save, getPathsHash, resolveFile and hasDirectory) are not used by any class and the 2 other methods need some tests using another classes. The 4 methods mentioned doesn't have documentation, if we remove them we can improve the coveralls percentage by +2.53% (53.23%), do you think it's possible to delete these methods? |
Mh, some of those are very useful at least. Need more tests. |
I'm still unfamiliarzed with some aspects of this lib, i'll test all this methods. |
|
I have managed to achieve 60.88% in coveralls implementing cache tests. davidsosavaldes/Sprockets-PHP@052b180 |
Nice. The only thing I'm afraid is that including bootstrap in the tests will make finding the issue much harder, whenever something changes. |
I was trying to use some filters but we can try something else, the bootstrap tests are deleted on commit: davidsosavaldes/Sprockets-PHP@b040cd5. |
So i recently acquire some experience using coveralls.io.
I think we could improve the tests using Codeception and make a code-coverage report to Coveralls, so the users can explore all the acceptance and unit tests that we realize and see the latest code-coverage statistics for this project.
Do you like the idea? (if you like the idea i can start working on a pull-request)
https://coveralls.io/features
The text was updated successfully, but these errors were encountered: