-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Files for their actual formats #35
Comments
@ermo did a tool for PWCU to help with some of this. He's a good resource for some of these changes. |
As I said in the main gitter channel, the various image libraries in the VS engine already know how to decode based on the actual content of the files regardless of their extension. To wit, if this hadn't worked, then none of the current assets that are actually DDS encoded would've been able to load as their extension is currently .png. Hence, it may make more sense to simply rename all image files @ministerofinformation called this virtualised file types FWIW. In the future, @ministerofinformation also suggested that we might tack on extra .image prefixes such as |
So my main objection to just
So while VS itself may be fine; we do also need to consider the tooling and environments that contributors will be using. Also, |
All fair points. In that case, I think the sanest approach is to build a small python-tool (for distribution with the engine), which can take a look at a known list of (image) extensions, check their magic type and rename the extension to the proper format and update sprites accordingly? Possibly with a This is predicated on the idea that having to manually edit and change stuff which can be trivially machine checked/verified/changed is not a good use of maintainer time. |
There are a number of files that have the incorrect file extension so the filename can be misleading.
*.dds
instead of*.png
*.spr
There may be others too.
The text was updated successfully, but these errors were encountered: