New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal server error if search would return no results #3

Open

twof opened this issue Oct 24, 2018 · 1 comment

twof commented Oct 24, 2018

example:
https://package.vapor.cloud/packages/search?name=asdfasdfsdfasdf&limit=10
returns

{
    "reason": "Something went wrong.",
    "error": true
}

The text was updated successfully, but these errors were encountered:

Author

twof commented Oct 24, 2018 •

edited

Loading

Issue is here. I think it ought to return an empty array instead if there are no results

https://github.com/vapor-community/PackageCatalogAPI/blob/master/Sources/App/Models/GitHub.swift#L63

Edit: Actually that shouldn't be causing the issue we're seeing since that wouldn't throw a 500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment