Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison in Memory #78

Open
MekWarrior opened this issue Oct 8, 2021 · 1 comment
Open

Comparison in Memory #78

MekWarrior opened this issue Oct 8, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@MekWarrior
Copy link
Collaborator

def benchmark_division_performance(trk_gt, trk_res, path_gt=None, path_res=None):

We should adapt benchmark_division _performance to work on a dict in memory rather than require the information for the comparison to come from existing .trk files written to disk.

@MekWarrior MekWarrior added the enhancement New feature or request label Oct 8, 2021
@willgraf
Copy link
Contributor

willgraf commented Oct 11, 2021

I think we can update this to check if the trk_gt is a path or dict, then load it appropriately.

That way we can be fully backward compatible but also allow in-memory comparisons.


UPDATE: this does not seem feasible, as both the y and lineage information are required for benchmarking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants