-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧: Stale Prs #2410
Comments
A starting measure to find stale prs is to find prs with |
Also good ones are |
Updated the description to include both |
@profnandaa Can I start working on this? |
You can take it |
You can go for it |
@rubiin I'm sorry if I sound dumb, but how would we contribute to the same PR and resolve conflicts if they were raised from other people's fork? Are we supposed to create our own fork and copy the changes from the Original PR? |
Yeah . Create your own fork, commit the changes done by the original author and resolve the merge conflicts in your own fork. |
Understood. Thanks for clarifying |
@Suven-p go for it |
I think its time to merge/close Prs that have been stale for too long . Most of them have merge conflicts which are restricting them from being merged while some have some small changes to be made.
Lets use this issue to report, and if needed reassign and merge them. Anyone upto the challenge , feel free to drop in the issue before you get started :)
Please find the list below:
https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+review%3Achanges-requested+sort%3Acreated-asc
https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land+sort%3Acreated-asc
The text was updated successfully, but these errors were encountered: