Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile view for upcoming commitments #162

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

ColinToft
Copy link
Collaborator

@ColinToft ColinToft commented Aug 21, 2024

Notion Ticket Link

Replace with Ticket URL

Implementation Description

  • Make the mobile view for upcoming commitments work
  • Remove the redundant "my upcoming meal donations" text

Steps To Test

  1. **Look at the upcoming meal commitments table (meal donor dashboard) at all sizes

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@ColinToft ColinToft marked this pull request as ready for review August 21, 2024 21:10
@ColinToft ColinToft requested a review from shahanneda August 21, 2024 21:10
Copy link

github-actions bot commented Aug 21, 2024

Visit the preview URL for this PR (updated for commit a29d658):

https://feeding-canadian-kids-staging--pr162-meal-donor-dashbo-g8nxzrio.web.app

(expires Thu, 29 Aug 2024 01:40:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004

Copy link
Contributor

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Colin this is great!

@shahanneda shahanneda merged commit 1b13339 into main Aug 22, 2024
4 checks passed
@shahanneda shahanneda deleted the meal-donor-dashboard-mobile branch August 22, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants