Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation when editing meal donation (modal) #160

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

ColinToft
Copy link
Collaborator

@ColinToft ColinToft commented Aug 20, 2024

Notion Ticket Link

Replace with Ticket URL

  • Update Meal donation modal on meal donor dashboard (Colin)
  • Make the additional notes not required in the meal donor edit page (Colin)
  • Make the meal description actually mandatory. (Colin)

Steps To Test

  1. Test that when editing a meal donation from the meal donor dashboard, the correct fields are required, and if you don't have them, you can't submit

What Should Reviewers Focus On?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

github-actions bot commented Aug 20, 2024

Visit the preview URL for this PR (updated for commit 9d173d6):

https://feeding-canadian-kids-staging--pr160-update-meal-reque-glzlwvym.web.app

(expires Thu, 29 Aug 2024 00:46:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004

Copy link
Contributor

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just took a quick look and tested using the onlien web interface!

@ColinToft ColinToft merged commit 27819ed into main Aug 22, 2024
4 checks passed
@ColinToft ColinToft deleted the update-meal-request-modal branch August 22, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants