Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jarydo/admin list view #149

Closed
wants to merge 65 commits into from
Closed

Jarydo/admin list view #149

wants to merge 65 commits into from

Conversation

shahanneda
Copy link
Contributor

@shahanneda shahanneda commented Jun 13, 2024

Notion Ticket Link

List view for admin pages

Implementation Description

  • Created list view for users and meal requests on admin account
  • On user list: added ability to activate/deactivate user from frontend, added redirect to users specific meal requests, added search by user
  • On meal requests: added unmatching/deleting meal requests

Steps To Test

  1. Confirm all functionality is as intended

What Should Reviewers Focus On?

  • There are still some outstanding items:
  1. Clicking any red button in the modal (delete/deactivate/unmatch turns green when loading, not entirely sure why this is the case)
  2. When activating/deactivating/deleting/unmatching the list doesn't refresh unless manually refreshing the page, I attempted to fix but got stuck
  3. Search - currently done with an ignore-case regex search, not sure if it should get more sophisticated than that. Also currently does not clear the query after searching, if this is the desired result can uncomment that behaviour in UserList.tsx
  4. When redirected from list of users to meal requests, there is no button to revert back to all meal requests other than clicking the top - this should probably be done for better UX

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

jarydo and others added 30 commits April 4, 2024 23:04
Co-authored-by: sophie-wjyang <[email protected]>
Co-authored-by: Shahan Neda <[email protected]>
* Very meaningful change

* Another meaningful change

* Another meaningful change

* Another meaningful change

* Fix CORS URLs
* Fix import

* Fix relative imports
* Fix import

* Fix relative imports

* Fix imports
* Fix import

* Fix relative imports

* Fix imports

* Fix backend import
* Fixed tricky timezone and date related bugs

* Lint
* Started work on fixing the get all users query

* Fixed bugs with offset and limit

* Ran linter
* Removed old dashboard pages

* Delete unused files
Copy link

github-actions bot commented Aug 28, 2024

Visit the preview URL for this PR (updated for commit ac9c490):

https://feeding-canadian-kids-staging--pr149-jarydo-admin-list-51wj7y7j.web.app

(expires Wed, 04 Sep 2024 04:09:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004

@jarydo jarydo marked this pull request as ready for review August 28, 2024 04:15
@shahanneda shahanneda closed this Aug 28, 2024
@shahanneda shahanneda deleted the jarydo/admin-list-view branch August 28, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants