Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site - Bug: CircleCI Test Builds Failing on PRs #2988

Closed
2 tasks done
RachelCorsino opened this issue Nov 25, 2024 · 0 comments · Fixed by #2995
Closed
2 tasks done

USWDS-Site - Bug: CircleCI Test Builds Failing on PRs #2988

RachelCorsino opened this issue Nov 25, 2024 · 0 comments · Fixed by #2995
Assignees
@RachelCorsino
Labels
Type: Bug A problem in the code

Comments

@RachelCorsino
Copy link
Contributor

Describe the bug

PRs are failing circleCI: test build test due to links to pages that have permanently moved to a new location. We need to update these links to the new URLs.

Steps to reproduce the bug

  1. Got to a recent site PR. See USWDS-Site: Replaced deprecated xlink:href code with recommended use of href #2926
     as an example.
  2. Scroll down to checks.
  3. Click "details" to the right of the ci/circleci: test build check.
    Here you can see all of the links showing a 301 error, indicating that these links have been moved.

Expected Behavior

All checks should pass.

Screenshots

Image

System setup

No response

Additional context

No response

Code of Conduct
@RachelCorsino RachelCorsino added the Type: Bug A problem in the code label Nov 25, 2024
@RachelCorsino RachelCorsino self-assigned this Nov 25, 2024
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Nov 25, 2024
@RachelCorsino RachelCorsino moved this to In progress in USWDS Core Project Data Dec 2, 2024
@RachelCorsino RachelCorsino mentioned this issue Dec 2, 2024
Merged
@RachelCorsino RachelCorsino moved this from In progress to Review in USWDS Core Project Data Dec 2, 2024
@mahoneycm mahoneycm moved this from Review to Fed Final Review in USWDS Core Project Data Dec 5, 2024
@amyleadem amyleadem removed the Status: Triage We're triaging this issue and grooming if necessary label Dec 5, 2024
@github-project-automation github-project-automation bot moved this from Fed Final Review to Done in USWDS Core Project Data Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RachelCorsino RachelCorsino

Labels
Type: Bug A problem in the code
Projects
USWDS Core Project Data
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

USWDS-Site: HTML-proofer and snyk updates uswds/uswds-site
2 participants
@amyleadem @RachelCorsino