Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Bug: Header demo code uses old link class #2406

Open
2 tasks done
dkolar opened this issue Jan 3, 2024 · 0 comments
Open
2 tasks done

USWDS-Site - Bug: Header demo code uses old link class #2406

dkolar opened this issue Jan 3, 2024 · 0 comments
Assignees
Labels
Needs: Confirmation We need to confirm that this is an issue Type: Bug A problem in the code

Comments

@dkolar
Copy link

dkolar commented Jan 3, 2024

Describe the bug

On the Header component page https://designsystem.digital.gov/components/header/ the "Component code" is using the outdated usa-nav-link class instead of the current usa-nav__link class for all of the "Simple link" menu items in all four "Component code" examples (Basic header, Basic header with megamenu, Extended header, and Extended header with megamenu).

Steps to reproduce the bug

  1. Go to https://designsystem.digital.gov/components/header/
  2. Scroll to the Basic header section https://designsystem.digital.gov/components/header/#basic-header (this is the first example section—it is a problem with the other three example sections as well)
  3. Expand the "Component code" and find the anchor element for "Simple link," which is around line 77.
  4. The class is set to usa-nav-link which no longer exists in USWDS. The class should instead be set to usa-nav__link.
  5. When viewing the live version of the demo code, the a bar should appear underneath the link when you hover over it (just like it does for the other menu items). Instead, no bar appears.

Expected Behavior

The sample code should use the class usa-nav__link instead of usa-nav-link and the live demo page should show a bar underneath the menu item when you hover over it.

Screenshots

image

System setup

  • Any web browser
  • Any OS

Additional context

No response

Code of Conduct

@dkolar dkolar added the Type: Bug A problem in the code label Jan 3, 2024
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Jan 3, 2024
@brunerae brunerae added Needs: Confirmation We need to confirm that this is an issue and removed Status: Triage We're triaging this issue and grooming if necessary labels Jan 25, 2024
@brunerae brunerae moved this to Scheduled in USWDS Core Project Data Jan 25, 2024
@brunerae brunerae added this to the 2024.03 March milestone Jan 25, 2024
@brunerae brunerae moved this from Scheduled to Ready to Schedule in USWDS Core Project Data Jan 25, 2024
@brunerae brunerae moved this from Ready to Schedule to Needs refinement in USWDS Core Project Data Jan 25, 2024
@brunerae brunerae removed this from the 2024.03 March milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Confirmation We need to confirm that this is an issue Type: Bug A problem in the code
Projects
Status: Needs refinement
Development

No branches or pull requests

3 participants