Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site - Bug: Incorrect markup in component package info #2362

Closed
mejiaj opened this issue Nov 16, 2023 · 0 comments · Fixed by #2363
Closed

USWDS-Site - Bug: Incorrect markup in component package info #2362

mejiaj opened this issue Nov 16, 2023 · 0 comments · Fixed by #2363
Assignees
@mejiaj
Labels
Added during Sprint Role: Dev Development/engineering skills needed Severity: 4 Minor functionality, workaround available

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Nov 16, 2023 •
edited
Loading

Incorrect markup

Causes display issues on component pages.

uswds-site/_includes/component-package.html

Line 18 in d12404d

<code>{{ dependency }}</code class="text-no-wrap">{% if forloop.last != true %}, {% endif %}

@mejiaj mejiaj self-assigned this Nov 16, 2023
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Nov 16, 2023
@mejiaj mejiaj moved this to In progress in USWDS Core Project Data Nov 16, 2023
@mejiaj mejiaj added Role: Dev Development/engineering skills needed Severity: 4 Minor functionality, workaround available Added during Sprint and removed Status: Triage We're triaging this issue and grooming if necessary labels Nov 16, 2023
mejiaj added a commit that referenced this issue Nov 16, 2023
@mejiaj
Fix markup in dependency table, closes #2362
19e45e5
@mejiaj mejiaj mentioned this issue Nov 16, 2023
Merged
@mejiaj mejiaj moved this from In progress to Review in USWDS Core Project Data Nov 16, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in USWDS Core Project Data Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejiaj mejiaj

Labels
Added during Sprint Role: Dev Development/engineering skills needed Severity: 4 Minor functionality, workaround available
Projects
USWDS Core Project Data
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

USWDS-Site - Bugfix: Fix markup in dependency table uswds/uswds-site
1 participant
@mejiaj