Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field in Log structure are not public #73

Closed
seofernando25 opened this issue Oct 21, 2023 · 0 comments · Fixed by #77
Closed

Field in Log structure are not public #73

seofernando25 opened this issue Oct 21, 2023 · 0 comments · Fixed by #77
Assignees

Comments

@seofernando25
Copy link
Contributor

seofernando25 commented Oct 21, 2023

https://github.com/uorocketry/hydra/blob/bbbe96e2cf73015d5c02c8b951232481dcf22259/libraries/messages/src/logging/log.rs#L15C1-L24

There is no way to access its contents after the log object is created.

This is bad because there is no way to discriminate it.

image

@seofernando25 seofernando25 changed the title Log structure is not public Field in Log structure are not public Oct 21, 2023
@eilayk eilayk linked a pull request Jan 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants