Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for recovery state does not wait for recovery #67

Open
NoahSprenger opened this issue Sep 7, 2023 · 4 comments
Open

Wait for recovery state does not wait for recovery #67

NoahSprenger opened this issue Sep 7, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@NoahSprenger
Copy link
Contributor

Turns out that +- 4m/s does not mean that the vehicle has landed 💯 🚀 🔥 Oops...
@NoahSprenger NoahSprenger mentioned this issue Sep 8, 2023
Merged
@NoahSprenger NoahSprenger reopened this Sep 8, 2023
@NoahSprenger
Copy link
Contributor Author

This is still not a great solution. Ideally I can wait 10 minutes after the vehicle finds it is not moving. Also I doubt +- 0.25 is small enough.

@NoahSprenger
Copy link
Contributor Author

I could take an average over say 2000 points since 2000 * 250 ms ~= 8 minutes and if this average is within an acceptable range, I can safely assume that the vehicle has landed.

@NoahSprenger
Copy link
Contributor Author

Ignore the previous, I act like I have infinite memory and to assume time between messages is not a solid implementation.

@NoahSprenger
Copy link
Contributor Author

NoahSprenger commented Jan 10, 2024 •
edited
Loading

Or just use a timer :) see the ATSAMDHAL TimerCounter.

@NoahSprenger NoahSprenger added the bug Something isn't working label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NoahSprenger