-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrollable content cannot dismiss #36
Comments
+1 |
1 similar comment
+1 |
Upstream issue emilkowalski/vaul#281 |
@zernonia hi, maybe this is solution emilkowalski/vaul#281 (comment) it is not the best one, but at least prevent strange things |
From a short check those lines from the upstream code: https://github.com/emilkowalski/vaul/blob/main/src/index.tsx#L577-L600 seem to be missing: https://github.com/radix-vue/vaul-vue/blob/main/packages/vaul-vue/src/controls.ts#L544-L560 which might be related to the scrolling issues I've notice when comparing |
Is this actually an upstream issue? Vaul's docs has an example on scrollable content and it seems to be fine, I just can't seem to make the same happen with this Vue port (Android 14; Chrome 130) Not sure if their docs has an up-to-date version of the library or not. |
Hi any news with this bug ? Personally, the solution of using data-vaul-no-drag also causes unwanted behavior during the first drags. |
Has anyone come up with a solution? The problem occurs only when we have "overflow-*" to the DrawerContent or its children, and happens only on touch devices. In original Shadcn UI website, they use Drawer for the menu with scrollable content, and that works fine. |
The drawer with scrollable content cannot be dismissed. pls see the code below
The text was updated successfully, but these errors were encountered: