Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change WriteString signature to a Write method (with io.Reader) #49

Open
gunnsth opened this issue Apr 14, 2019 · 1 comment
Open

Change WriteString signature to a Write method (with io.Reader) #49

gunnsth opened this issue Apr 14, 2019 · 1 comment
Labels
core Package core major Major changes requiring major version upgrades performance

Comments

@gunnsth
Copy link
Contributor

gunnsth commented Apr 14, 2019

The string type is really not the right one for the writer and the eventual output is always []byte. Would make sense to change the signature to Write(io.Reader) instead of the WriteString. Easy to use the interface for any kinds of testing as well. May improve performance.
@gunnsth gunnsth transferred this issue from unidoc/unidoc May 24, 2019
@gunnsth gunnsth mentioned this issue May 3, 2020
Open
@gunnsth
Copy link
Contributor Author

gunnsth commented Jun 2, 2020 •
edited
Loading

Related #55

@gunnsth gunnsth added major Major changes requiring major version upgrades performance core Package core labels Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Package core major Major changes requiring major version upgrades performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gunnsth