Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make line height a property of TextChunk #183

Open
gunnsth opened this issue Oct 8, 2019 · 1 comment
Open

Make line height a property of TextChunk #183

gunnsth opened this issue Oct 8, 2019 · 1 comment
Labels
creator enhancement New feature or request

Comments

@gunnsth
Copy link
Contributor

gunnsth commented Oct 8, 2019 •
edited
Loading

Description

With reference to discussion in #181 more specifically #181 (comment)
TextChunk is not self-sufficient when it comes to calculating its own height as it does not have a line height property.

Currently Line height is a property of Paragraph / StyledParagraph. In the future it would be nice if the line height was a property of the TextStyle so that TextChunk can make needed calculations internally.

Requires some investigation to determine if this can be accomplished without breaking changes etc.

Expected Behavior

A clear and concise description of what you expected to happen.

Actual Behavior

Currently line height is a property of Paragraph / StyledParagraph.

Attachments

N/A
@gunnsth gunnsth added the enhancement New feature or request label Oct 8, 2019
@gunnsth gunnsth mentioned this issue Oct 8, 2019
Merged
@gunnsth gunnsth added the creator label Jun 2, 2020
@sc-ethan
Copy link

Hi @gunnsth, I was wondering if we had any updates regarding this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
creator enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gunnsth @sc-ethan