Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect fixed payload length for NavPosVelTime? #33

Open
sorenrade opened this issue Jul 27, 2022 · 1 comment
Open

Incorrect fixed payload length for NavPosVelTime? #33

sorenrade opened this issue Jul 27, 2022 · 1 comment

Comments

@sorenrade
Copy link

Hi! Thanks for the great crate!

I'm working off of the u-blox 7 Protocol Specification V14 document.

The payload length of the NavPosVelTime should be 84 bytes according to this spec. See NAV-PVT on page 158. If you are working off a different spec that no longer matches this it's probably best to note what version you support in the README.

https://github.com/lkolbly/ublox/blob/6422f57cf98aa39e3660377de295909e40eeb499/ublox/src/ubx_packets/packets.rs#L90

@lkolbly
Copy link
Collaborator

lkolbly commented Sep 11, 2022

Hi! Thanks, sorry for my delay in responding. Yeah, most of the code is developed for the M8 protocol, although it's becoming more of an ambiguous combination.

The goal is to support "all" (or at least multiple) protocols. I think this crate is going to have to be majorly refactored, I'm thinking maybe having multiple submodules for the different protocols. I had previously wanted to maintain a sort of protocol agnosticism, so you didn't have to figure out what protocol your device talked in order to use the crate. But, I think in practice people will know what device they have.

All that is to say, yes this is a huge problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants