Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

--dev not checking for consistency in node_modules #91

Open
vvo opened this issue Nov 4, 2015 · 5 comments
Open

--dev not checking for consistency in node_modules #91

vvo opened this issue Nov 4, 2015 · 5 comments

Comments

@vvo
Copy link

vvo commented Nov 4, 2015

package.json:

{
  "name": "shrinkwrap-test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "Algolia <[email protected]> (https://github.com/algolia/)",
  "license": "MIT",
  "dependencies": {
    "async": "^1.5.0"
  },
  "devDependencies": {
    "lodash": "^3.10.1"
  }
}

node_modules:

> tree node_modules 
node_modules
└── async
    ├── CHANGELOG.md
    ├── dist
    │   ├── async.js
    │   └── async.min.js
    ├── lib
    │   └── async.js
    ├── LICENSE
    ├── package.json
    └── README.md

Running npm-shrinkwrap --dev is a success:

> npm-shrinkwrap --dev
wrote npm-shrinkwrap.json

I really do not know if that's expected behavior, I would say no.

I am using the npm-shrinkwrap as part of our build but also CI test, so that we can ensure an added package in package.json was also added to shrinkwrap.

What do you think?

@vvo
Copy link
Author

vvo commented Nov 4, 2015

What's even weirder is that running npm install WILL install lodash (declared as devDependency), maybe that's more of an npm issue. Do you have insights?

@Raynos
Copy link
Contributor

Raynos commented Nov 4, 2015

Is this npm-shrinkwrap@5 or npm-shrinkwrap@200 ?

@vvo
Copy link
Author

vvo commented Nov 4, 2015

This is npm-shrinkwrap@5, node v4, npm@2

@vvo
Copy link
Author

vvo commented Nov 4, 2015

Just tried with npm-shrinkwrap@200 (seems like we should use this one since we use npm2), same result

@vvo
Copy link
Author

vvo commented Nov 16, 2015

Any new on this one?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants