Skip to content
This repository has been archived by the owner on Apr 11, 2022. It is now read-only.

String as script source in addition to File #53

Open
sorenbs opened this issue Mar 8, 2017 · 1 comment
Open

String as script source in addition to File #53

sorenbs opened this issue Mar 8, 2017 · 1 comment

Comments

@sorenbs
Copy link

sorenbs commented Mar 8, 2017

Would you accept a pull request that makes it possible to use a string as source instead of a File?

NodeEnvironment already exposes this

public NodeScript createScript(String scriptName, String script, String[] args)

but it is not exposed in Engine:

case class ExecuteJs(
                        source: java.io.File,
                        args: immutable.Seq[String],
                        timeout: FiniteDuration,
                        timeoutExitValue: Int = Int.MinValue,
                        environment: Map[String, String] = Map.empty
                        )
@benmccann
Copy link

Yes, pull requests accepted. However see #43 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants