-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade sass to namespaced built-ins #64
Comments
Thanks for writing in! I'm struggling to find the "should be requested" piece in the documentation (found the "no conflict" benefit, but we aren't defining anything new for lists?). Can you link me to that? One big concern I have is this only seems to be supported by Dart Sass, which breaks support for both LibSass and Ruby Sass. |
@twolfson The templates are using the By requested, I meant that the function won't be just used by itself as before, but there should be the addition of the I'm not sure how it would be possible to support both syntaxes. Maybe by having a way to select which templates one would like to use with "sass import" or with "sass modules"? |
Got it. I somehow read the top of https://sass-lang.com/documentation/values/lists/ and assumed Yea, it's been a while since I've maintained this library, and there's a lot of Sass/SCSS templates (3x documented + 3x retina variations). How about we repurpose the |
@twolfson The "functions" options could work since "nth" is only used in the mixins and not in the variables, otherwise it would be strange |
Hmm, yea -- good point. I was trying to be too clever. Let's add a Do you have bandwidth to pick this up? (I'm glad to handle the documentation part, but lack time for the library portion and tests) |
Recent versions of sass introduce namespaced built-ins: sprite templates in this project use the
nth
function, which now should be requested with a@use "sass:list";
at the beginning of the file, and then referred to withlist.nth
.The text was updated successfully, but these errors were encountered: