You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since moving to dynamic loading, there is no functional need for tree-sitter-ocaml and tree-sitter-json to be dependencies. Technically speaking, they're dev-dependencies, so don't impact the release build (but nonetheless make the Cargo.toml a bit confusing):
tree-sitter-json is used in topiary-core::tests.
tree-sitter-ocaml is used in topiary-core's benchmarking.
topiary-core ought to be tested. Using a small grammar like JSON seems like a reasonable option; although, if there's some stub grammar that can be used for this kind of testing, maybe that would be more appropriate.
Benchmarking against OCaml makes sense as the grammar and our formatting queries are non-trivial. However, perhaps this can be moved out of topiary-core and into a separate project, which can then make use of topiary-config's dynamic loading support.
The text was updated successfully, but these errors were encountered:
I'm currently adding dependencies to tree-sitter-ocaml in topiary-core for #500. If we do something about it for the benchmarks, it should also work for comment processing tests in topiary-core.
Since moving to dynamic loading, there is no functional need for
tree-sitter-ocaml
andtree-sitter-json
to be dependencies. Technically speaking, they're dev-dependencies, so don't impact the release build (but nonetheless make theCargo.toml
a bit confusing):tree-sitter-json
is used intopiary-core::tests
.tree-sitter-ocaml
is used intopiary-core
's benchmarking.topiary-core
ought to be tested. Using a small grammar like JSON seems like a reasonable option; although, if there's some stub grammar that can be used for this kind of testing, maybe that would be more appropriate.Benchmarking against OCaml makes sense as the grammar and our formatting queries are non-trivial. However, perhaps this can be moved out of
topiary-core
and into a separate project, which can then make use oftopiary-config
's dynamic loading support.The text was updated successfully, but these errors were encountered: