Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found a dot that is not rendered at bottom right of screen. #53

Open
BobDNA opened this issue Oct 22, 2021 · 2 comments
Open

Found a dot that is not rendered at bottom right of screen. #53

BobDNA opened this issue Oct 22, 2021 · 2 comments
Assignees

Comments

@BobDNA
Copy link

BobDNA commented Oct 22, 2021

Is that dot is by design or bug?
I used :
ESP-IDF 4.3.1
TTGO T-DISPLAY

I found this dot in your example too (esp_gfx and esp_effect).

@tuupola
Copy link
Owner

tuupola commented Oct 22, 2021

Sounds like an off by one bug somewhere. Will check.

@tuupola tuupola self-assigned this Oct 22, 2021
@BobDNA
Copy link
Author

BobDNA commented Oct 23, 2021

OK, I think I found this bug. It is not a bug in hagl library. It is a bug related to hagl_hal_clear_screen() function in hagl_esp_mipi library which is used in hagl_hal_triple.c and hagl_hal_double.c.

The line 172 in hagl_hal_triple.c and line 187 in hagl_hal_double.c

Both lines may need to be changed from size_t count = DISPLAY_WIDTH * DISPLAY_HEIGHT; --> size_t count = DISPLAY_WIDTH * DISPLAY_HEIGHT +1;

Not sure is this correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants