Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clippy in ci #542

Open
cospectrum opened this issue Dec 23, 2024 · 3 comments
Open

Run clippy in ci #542

cospectrum opened this issue Dec 23, 2024 · 3 comments

Comments

@cospectrum
Copy link

The contribution guide suggests running clippy. There are several pull requests that use the cargo clippy fix. But at the same time, I did not find a ci job that would check clippy, which looks strange.

@travenin
Copy link
Contributor

Running clippy in CI for every PR would be very good idea to keep codebase in better shape. However, there are quite a lot of issues in the main branch currently. Majority of them should be fixed first.

However, I am interested in working on this issue.

@pereman2
Copy link
Collaborator

I've been avoiding this as much as possible because I hate some things from clippy, but overall it is a good direction. I would suggest using this command as the entrypoint cargo clippy -- -A clippy::all -W clippy::correctness -W clippy::perf -W clippy::suspicious --deny=warnings

@travenin
Copy link
Contributor

Good point. It's not necessary to keep clippy perfectly happy. Your suggested command looks good place to start. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants