Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ozone Moderation Types Opt-In for Generated Lexicons #31

Open
skiniks opened this issue Dec 4, 2024 · 0 comments
Open

Make Ozone Moderation Types Opt-In for Generated Lexicons #31

skiniks opened this issue Dec 4, 2024 · 0 comments

Comments

@skiniks
Copy link
Contributor

skiniks commented Dec 4, 2024

Currently, our lexicon type generation includes the Ozone moderation types by default. After analysis, I found this adds ~35KB (20%) to the generated types file size:

  • With Ozone: 182,688 bytes
  • Without Ozone: 146,663 bytes

Considerations

  • Are moderation capabilities planned for Nimbus?
  • It aligns with keeping the core package lean
  • 20% size reduction is meaningful

Implementation Options

We could either:

  1. Add a CLI flag (e.g. --include-ozone) to opt-in when generating types
  2. Create a separate @tsky/lexicons-ozone package for moderation types
  3. Not include Ozone types at all

Questions

  • Which approach do we prefer for handling this?
  • Are the types fine as is with Ozone included?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant