Coin selection bug in walletconsole.

[PopeNobody]

Describe the bug
A clear and concise description of what the bug is.
typing "coin bch" in walletconsole and generating an address produced an etherium send address

To Reproduce
Steps to reproduce the behavior:

1. Fire up walletconsole
2. Type "coin bch"
3. type generateDefault
4. Observe an etherium address

Expected behavior
I expected a Bitcoin Cash address

Screenshots
Sorry, already fixed my version.

Additional context
Add any other context about the problem here.
The problem is in Coins.h and/or registry.json, depending on how you look at it.
The registry.json issue is that both BitcoinCash and SmartBCH were listed with an id of BCH. Since Bitcoin Cash went into the map first, it was displaced by SmartBCH, an Etherium Token.

For the time being, I chanced the id in registry.json for my fork to call it sbch.
I also changed the Coins.cpp code to check for duplicates in all four maps ( id/name/number/symbol ) that it used to index it's collection of coins. I also modified the Coins class to store all of the coin objects in a vector, and changed the index maps to be map<string,int> and map<int,int> as appropriate, where the int value corresponded to the vector index. This fixed it.

I was working on some other things when I found this, but here is a patch that includes the fixes.

There is also a problem where consolewallet goes into an endless loop of printing prompts when it receives a ctrl-d. I fixed this in CommandExecutor.cpp by checking the result of the call to getline, and breaking the loop when it went false.

fixes.gz

[PopeNobody]

Well, after "fixing" this "bug", i noticed that the unit test which makes sure that the behavior I observed is maintained started failing ... so go figure?

Sorry about that.

Still would not hurt to fix the endless loop on eof.