New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove protection for system binds from commands API #5

Open

bovine3dom opened this issue Apr 18, 2021 · 0 comments

Member

bovine3dom commented Apr 18, 2021

https://searchfox.org/mozilla-central/rev/1f4e023df8ff04b893ca792492f1e2e9629bfddb/toolkit/modules/ShortcutUtils.jsm#315

and

https://searchfox.org/mozilla-central/rev/1f4e023df8ff04b893ca792492f1e2e9629bfddb/toolkit/modules/ShortcutUtils.jsm#287

The error "shortcuts-system" is the one thrown when you try to bind to one via the UI.

OTOH no error is thrown if you bind using the API rather than the GUI, so maybe getting rid of these checks isn't good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment