New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Chart)!: 📦 add separated chart for CRDs #1223

Open

darkweaver87 wants to merge 32 commits into traefik:master from darkweaver87:feat/crds

Contributor

darkweaver87 commented Oct 14, 2024 •

edited

Loading

What does this PR do?

This PR introduces a separate chart used by the main one to install CRDs.
The dependency between the main chart and the CRDs one will be added once CRDs one will be released.

Motivation

More

Yes, I updated the tests accordingly
Yes, I updated the schema accordingly
Yes, I ran make test and all the tests passed

darkweaver87 added kind/enhancement kind/proposal labels

darkweaver87 force-pushed the feat/crds branch 2 times, most recently from bd35651 to b674cf7 Compare

October 14, 2024 08:39

mloiseleur reviewed

View reviewed changes

traefik-crds/templates/crds.yaml Outdated Show resolved Hide resolved

darkweaver87 changed the title ~~feat: 📦 add separated chart for CRDs~~ feat!: 📦 add separated chart for CRDs

mloiseleur reviewed

View reviewed changes

traefik/values.yaml Outdated Show resolved Hide resolved

darkweaver87 force-pushed the feat/crds branch 9 times, most recently from 9087b4b to e1eb8a0 Compare

October 14, 2024 14:53

darkweaver87 mentioned this pull request

feat(Gateway API): ✨ standard install CRD v1.2.0 #1221

Merged

3 tasks

darkweaver87 requested a review from mloiseleur

October 15, 2024 07:51

mloiseleur linked an issue

that may be closed by this pull request

CRD only Helm chart for Traefik #1141

Open

2 tasks

rgdev mentioned this pull request

[Gateway API] Support for GRPCRoute v1 (stable channel) linkerd/linkerd2#13032

Open

mloiseleur reviewed

View reviewed changes

.github/workflows/release.yml Show resolved Hide resolved

mloiseleur reviewed

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

mloiseleur reviewed

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

mloiseleur reviewed

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

mloiseleur reviewed

View reviewed changes

traefik/crds/kustomization.yaml Outdated Show resolved Hide resolved

mloiseleur requested changes

View reviewed changes

Contributor

mloiseleur left a comment

The CI needs to be tested, with a tag on your fork.
The documented CRDs upgrade process should still work. I see (at least) two options:
a. Keep and copy crd files
b. Update CRD upgrade instruction to use them in the new directory

darkweaver87 force-pushed the feat/crds branch 2 times, most recently from e9619df to 6a67459 Compare

October 21, 2024 06:50

Contributor Author

darkweaver87 commented Oct 21, 2024 •

edited

Loading

Tested on my own account as seen with you 👍

darkweaver87 requested a review from mloiseleur

October 21, 2024 15:14

darkweaver87 and others added 28 commits

December 16, 2024 08:10


          fix: CI

69ba344


          fix: update CI

be6d99f


          fix: add hub only when api management is enabled

f829dd1


          fix: CI

c490849


          fix: snapshot dir

55ba3a8


          fix: remove dependency while not published


          fix: apply suggestions from @mloiseleur's code review

fd01dc0

Co-authored-by: Michel Loiseleur <[email protected]>


          fix: tag exist condition

412fa8c


          fix: charts_dir

31eafa9


          fix: changelog

fb5215c


          fix: get chart version

f8dce18


          fix: reduce changelog on patches

5f39c43


          fix: ci workflow to handle two different releases

a5b407a


          fix: Chart.yaml

d0c2fc1


          fix: more reliable changelog.sh

0ac444e


          fix: apply suggestions from @mloiseleur's code review

4a36ec0

Co-authored-by: Michel Loiseleur <[email protected]>


          fix: preserve CRDs by default

958b1e3


          fix: add some annotations on CRDs

09c2420


          fix: schemas and helper

dc90364


          fix: doc

ff1c676


          fix: CI

39fc5a3


          fix: CI

2af71bc


          fix: review

34e03a9


          fix: doc

ac7881b


          fix: tests + add condition

8d81378

fix

605bf17


          fix: doc

2a499fc


          fix: rename gateway api + add enabled flag

1f5ddd5

darkweaver87 force-pushed the feat/crds branch from b296543 to 1f5ddd5 Compare

December 16, 2024 07:14


          fix: doc

a21dae9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot/no-merge kind/enhancement kind/proposal