Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access violation on shift-tab #322

Open
yennor opened this issue Dec 19, 2024 · 4 comments
Open

access violation on shift-tab #322

yennor opened this issue Dec 19, 2024 · 4 comments

Comments

@yennor
Copy link

yennor commented Dec 19, 2024

  • Open a new note
  • press tab
  • write "asdf"
  • press shift-tab
    -=> access violation
    Screenshot_20241219_114721

in general as it seems it is not possible to

  • add more than one tab
  • once you-ve added a tab, you can't jump back to the beginning of the line (remove the tabulator). Neither shift-tab nor backspace to work
@davidbannon
Copy link
Member

Hmm, good catch.

Shift Tab removes the Tab but if your cursor is at the end of the line, bang !

The whole tab thing is, IMHO unusable. Its an indent, not a tab, its is limited to one indent and is confusing, ugly and, as you have demonstrated, dangerous.

I reserved the Tab key to do some real tabbing but the nature of KMemo, the underlying component that does the actual editor makes that impossible.

I am sorely tempted to remove current Tab functionality and, do as you (and commen sense) suggest, use it to control bullets. Bullets would still be Alt ,left/right arrow but a user of the 0.40 release who might be using that indent would not be too surprised if they got a bullet instead ?

Davo

@yennor
Copy link
Author

yennor commented Dec 20, 2024

I've got family visit, so no time to do testing. Officially I'm only on a beer run ;-).
But just a general remark. Don't forget to think about, what happens when text with tabulators in it, are copy'n pasted?
Eg. some short scripts or similar?

  • Will tabs just be removed?
  • Will a tab be replaced with a space (or maybe eg. 4 spaces)?
  • will tabs be displayed as bullet points?
  • will everything crash?

When copying the text back out of tomboy, maybe the user would like to have his tabs back?
What does the user expect when copying bullet points (with maybe several intentions) out of tomboy? (Spontaneously I've got no idea ;-) )

@aguador
Copy link
Contributor

aguador commented Dec 20, 2024

Replicated with 0.41 Gtk2 with X11 on the following:

  • Mageia 10 - E
  • Artix - E
  • Artix - XFCE Session

However, I wonder if the ng behavour should be changed (as requested in Issue 323) or an upstream (Kmemo) bug fix sought...

davidbannon added a commit that referenced this issue Dec 26, 2024
@davidbannon
Copy link
Member

OK, this relates to ( #324, #323 and #322 ) but I'll answer here because this was the first logged.

New key usage further down !

OK, I have had a pretty miserable XMas (due to some family issues) but had plenty of time to play here.

Firstly, yennor, AV fixed. That was easy.

Then, can we do Bullets with Tab key ? Maybe, I have committed code to do so but it is not the way Tomboy did it. But I see bullets as more useful than Indents. (Tomboy used Tab key for Indent).

KG576 - I have committed code that will Indent paragraphs when it imports legacy notes that have a line starting with a Tab, ie Tomboy style. Note it does NOT indent just the first line, it indents the whole para. Tomboy, in some releases, indented just the first line, word processor like.

Now, how to do it ?

Pressing the Tab key with the cursor somewhere in a para (with no existing indent) will (at present) create a Bullet (or extend a Bullet).

Pressing the Ctrl-Tab keys with the cursor somewhere in a para (with no bullet set) will (at present) indent that para.

Pressing Shift-Tab keys in a para with either bullet or indent will reduce that bullet of indent.

Bullets are still controlled by the traditional Tomboy Alt Arrow

Juts load an old, legacy note containing Tabs to see how well it handles them !

At present, its only possible to trigger one level of Indent (but importing a Legacy note with more might be rendered correctly).

Its not possible, and will never be possible to embed tabs in text to create "columns" of data. Thats just not going to happen.

Anyone who wants a try (please, please do) should tell me their OS and, if Linux, Widget set (see tomboy-ng About) and I'll make a alpha test version for them.

Thanks for reporting / contributing !

Davo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants