Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stop batch runs when one of the hosts is not available #225

Open
thekorn opened this issue Nov 24, 2014 · 4 comments
Open

Don't stop batch runs when one of the hosts is not available #225

thekorn opened this issue Nov 24, 2014 · 4 comments

Comments

@thekorn
Copy link
Collaborator

thekorn commented Nov 24, 2014

I you do a fix node:all and one of the nodes inbetween is not available the run will stop immediatly with an error - which is extremly annoying.

to prevent this from happening we can use env.skip_bad_hosts = True
The only remaining question is if it is safe to set it to True in all cases, of if this needs an commandline option, with False (the current behaviour) as default?

@thekorn
Copy link
Collaborator Author

thekorn commented Nov 24, 2014

@tobami, any idea on that one?

@tobami
Copy link
Owner

tobami commented Nov 24, 2014

When using the concurrency option failures are ignored, so we have a start there. I would not make it default in a first version, as that changes assumptions and may break something for some users.

I would call the variable skip_failures.
The implementation I guess would be to catch the errors in the node runner

@thekorn
Copy link
Collaborator Author

thekorn commented Nov 24, 2014

the problem here is that - if we only change this environment variable to True - we won't really implement a skip_failures feature, it is just a skip_on_connection_error but not a skip on chef config errors.

Do you still think the naming makes sense, even with this tiny change, or do you want a full implementation of this feature?

@tobami
Copy link
Owner

tobami commented Nov 24, 2014

OK, let's begin with skip_on_connection_error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants