Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved docker-compose.yml and own Dockerfile #85

Open
minyk opened this issue Mar 5, 2017 · 1 comment
Open

Improved docker-compose.yml and own Dockerfile #85

minyk opened this issue Mar 5, 2017 · 1 comment

Comments

@minyk
Copy link

minyk commented Mar 5, 2017

Hi @tleyden First of all, this is what I need! Thank you!

After some hours with docker-compose up and down, I think I improve some part of the docker-compose.yml. See my branch: https://github.com/minyk/open-ocr/tree/feature/docker-compose/docker-compose and major changes are here:

Add own open-ocr/Dockerfile and open-ocr-preprossor/Dockerfile for local build.

  • Update container OS to Ubuntu 16.04 LTS.
  • Using mirror://mirror.ubuntu.com for apt.
  • Layer build command of Dockerfile carefully for reusability.
  • Comment out unnecessary languages from open-ocr/Dockerfile ’s language section(all languages are enabled by default).
  • open-ocr-preprocessor is based on open-ocr image. Save some disk space.

Modify docker-compose.yml.

  • Remove tcp port mapping of rabbitmq service: depends_on or link is enough for.
  • Add healthcheck for rabbitmq service. No more connection refused error.
  • Reorder container startup. This is needed to build open-ocr:build image before open-ocr-preprossor:build.
  • All scripts directories are mounted with read only mode.

How about these changes? If you may accept, I will send PR for these.

Thank you again for great works!

@tleyden
Copy link
Owner

tleyden commented Oct 10, 2017

These sound like good changes! Can you rebase your branch on the current master and send a PR? Somehow your branch was based on an older version of master (14 commits behind)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants